Re: [VOTE] JSON_THROW_ON_ERROR
| From: | Derick Rethans | Date: | Tue, 26 Sep 2017 10:01:58 +0000 |
| Subject: | Re: [VOTE] JSON_THROW_ON_ERROR | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-100775@lists.php.net to get a copy of this message | ||
On Mon, 25 Sep 2017, Andrea Faulds wrote:
> Hi everyone,
>
> https://wiki.php.net/rfc/json_throw_on_error
>
> Voting opens today, 2017-09-25, and ends in 10 days' time, 2017-10-05. Under
> the terms of the voting RFC this only needs 50%+1 but I'll feel guilty if it's
> not 2/3 so it's 2/3.
>
> Happy voting, please ask if there's anything needing clarifying.
I'm going to be in favour, but I was wondering whether the name of the
exception "JsonException" is a good thing? I would still introduce it,
but probably subclass a "JsonCodingException" to signal just an
exceptional code while encoding/decoding. I can see future exceptions
being thrown from the extension, where you then get confusion (or
conflicts with error codes).
cheers,
Derick
--
https://derickrethans.nl | https://xdebug.org | https://dram.io
Like Xdebug? Consider a donation: https://xdebug.org/donate.php
twitter: @derickr and @xdebug