Re: com php-src: Add line numbers to Opcache's zend_dump_op() debug output: ext/opcache/Optimizer/zend_dump.c ext/opcache/tests/opt/dce_001.phpt
ext/opcache/tests/opt/dce_002.phpt ext/opcache/tests/opt/dce_003.phpt ext/opcache/tests/opt/dce_004.phpt ext/opcache/tests/opt/dce_005.phpt
ext/opcache/tests/opt/dce_006.phpt ext/opcache/tests/opt/dce_007.phpt ext/opcache/tests/opt/dce_008.phpt ext/opcache/tests/opt/sccp_001.phpt
ext/opcache/tests/opt/sccp_0
| From: | Rasmus Lerdorf | Date: | Fri, 06 Oct 2017 19:59:22 +0000 |
| Subject: | Re: com php-src: Add line numbers to Opcache's zend_dump_op() debug output: ext/opcache/Optimizer/zend_dump.c ext/opcache/tests/opt/dce_001.phpt ext/opcache/tests/opt/dce_002.phpt ext/opcache/tests/opt/dce_003.phpt ext/opcache/tests/opt/dce_004.phpt ext/opcache/tests/opt/dce_005.phpt ext/opcache/tests/opt/dce_006.phpt ext/opcache/tests/opt/dce_007.phpt ext/opcache/tests/opt/dce_008.phpt ext/opcache/tests/opt/sccp_001.phpt ext/opcache/tests/opt/sccp_0 |
||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-100834@lists.php.net to get a copy of this message | ||
On Fri, Oct 6, 2017 at 12:04 PM, Sara Golemon <pollita@php.net> wrote:
> On Fri, Oct 6, 2017 at 10:18 AM, Rasmus Lerdorf <rasmus@lerdorf.com>
> wrote:
> > Sara/Remi do you mind if I merge this into 7.2? This affects opcache
> debug
> > output only and I want to start playing with some DCE reporting from
> Phan.
> > Having the original line numbers available will make that more effective.
> >
> > http://git.php.net/?p=php-src.git;a=commitdiff;h=
> 9fe6b29356923c23fadf610a9fa421cff8b06d6d
> >
> Literally two low-risk lines of actual change to a debug-only path?
> Zero objections from me.
Correct, the zend_dump_op() call I tweaked is only ever called if
opcache.debug_level is set. The bulk of the patch is to add the resulting
line numbers to the tests that use this debug info to verify the output
from the optimizer.
-Rasmus