Re: Minor BC break in gettype()
| From: | Sara Golemon | Date: | Mon, 20 Nov 2017 20:35:11 +0000 |
| Subject: | Re: Minor BC break in gettype() | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-101146@lists.php.net to get a copy of this message | ||
Good enough for me. Thanks!
On Mon, Nov 20, 2017 at 2:13 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> I think PHP 7.2 is a good place for these minor break.
>
>
> Dmitry.
>
> ________________________________
> From: Sara Golemon <php@golemon.com>
> Sent: Saturday, November 18, 2017 12:17:24 PM
> To: Dmitry Stogov; internals@lists.php.net
> Subject: Minor BC break in gettype()
>
> https://3v4l.org/kRON7
>
>
> https://github.com/php/php-src/commit/f00d1c72b4dbaf3532569d20efc1da7c408605d6
>
> The above patch optimizes calls to gettype() into an opcode, however the
> strings returned for closed resources has changed relative to 7.1 and
> earlier.
>
> The newer output is objectively better, but it's technically a BC break.
>
> Was this intentional, and are we fine letting this change stand?
>
> -Sara