Re: RC3RC1

* Thus wrote Daniel Fahlgren (guru@acc.umu.se): > On Thu, May 27, 2004 at 08:11:17PM +0000, Curt Zirzow wrote: > > * Thus wrote Andi Gutmans (andi@zend.com): > > > Please test. If there are no critical problems I'll release RC3 tomorrow > > > which I think will be the last RC for 5.0. > > > > > > > I'm getting an error during compile, > > [..] > > In file included > > from /usr/home/curt/source/php-5.0.0RC3RC1/Zend/zend.h:244, > > from /usr/home/curt/source/php-5.0.0RC3RC1/main/php.h:34, > > from /usr/home/curt/source/php-5.0.0RC3RC1/ext/standard/proc_open.c:25: > > /usr/home/curt/source/php-5.0.0RC3RC1/Zend/zend_hash.h:39: > > error: syntax error before "uint" > > I guess you are using Solaris or AIX, right? I figured out a way to get > it to compile cleanly on Solaris, but I'm not sure if Wes fixed the > CVS.. Any how.. if you add > > #define __EXTENSIONS__ > #define _ALL_SOURCE > #include <sys/types.h> > Yep, those defines are there, but If I add #define __BSD_VISIBLE 1 It works. I tracked it down that it broke for me at revision 1.21 (the pty support for proc_open), the macro #define _XOPEN_SOURCE 500 causes my system to change which POSIX version to compile with. If I take that _XOPEN_SOURCE line out it compiles fine. Is that #define needed? I have a strong feeling the __EXTENSIONS__ and _ALL_SOURCE macros could be remove as well. Curt -- "I used to think I was indecisive, but now I'm not so sure."