Re: [RFC] Reproducible Builds Support

Hi! >> I think the best solution here would be to have another variable to >> override this. > > The issue with this approach would be that every distribution has to set > this variable. I know it's the same with SOURCE_DATE_EPOCH, but that is > well established. All distros that want reproducible build of PHP. But I assume they need to do some special magic to initiate reproducible build anyway, if so, we could document the procedure of setting up reproducible build in some readme file, and make it easy to set it up. They won't need to set it up for all builds, just for PHP build, and since most use special scripts to build PHP anyway, it shouldn't be too hard to add. >> If those old systems run PHP and need uname, changing stuff there is >> probably harder and more expensive than on other systems. With this in >> mind, I'd rather not mess with it, especially for a purpose that can >> easily be achieved without it. > > Hmmm true, but the fallback being the hostname where PHP was build on > seems a little bit odd, doesn't it? Yes, but I'd follow "Chesterton fence" principle here. Maybe we could use some ifdefs and configure magic to ensure this is actually not happening on the kind of systems where reproducible builds are run? -- Stas Malyshev smalyshev@gmail.com