Re: C++ and FAST_ZPP macros

On Tue, Dec 19, 2017 at 3:29 PM, Anatol Belski <ab@php.net> wrote: >> As the blog post notes, it's a simple matter to work around the bug in extension >> code (indeed, an extension can simply opt to not use FAST_ZPP). On the other >> hand, the fix is pretty basic, and existing functionality of the default expected >> type effectively being Z_EXPECTED_LONG (because both have a value of zero) is >> just a bit.... >> weird. >> >> Thoughts? If I don't hear anything in a week, I'll just apply to 7.1 and merge >> up. >> > C++11 requires a validity scope for enums, thus this change is unavoidable. > IMO your second suggestion were safer in the spirit of BC - Z_EXPECTED_LONG > instead of IS_UNDEF by default, and a new in master. Just because a workaround > is possible and otherwise the issue is not critical. > Yeah, the more I think about it, the more I realize that's the more prudent approach given the non-critical nature of this. Could you clarify as 7.0 RM if you want this on your branch? AIUI we're in security-only for 7.0 now, yes? -Sara