Re: Proposal to run all tests with and without strict_types enabled
| From: | Christoph M. Becker | Date: | Sun, 11 Feb 2018 23:34:50 +0000 |
| Subject: | Re: Proposal to run all tests with and without strict_types enabled | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-101828@lists.php.net to get a copy of this message | ||
On 12.02.2018 at 00:03, Pedro Lacerda wrote:
> So a new function check_strict_types() was needed to expose
> ZEND_ARG_USES_STRICT_TYPES() enabling .phpt tests to check for it in the
> --SKIPIF-- section if needed.
Umm, I wonder whether a magic constant (say,
__STRICT_TYPES__) would
be more appropriate.
> And the implementation draft is at this repository:
>
>
> https://github.com/php/php-src/compare/master...pslacerda:experimental/strict_testing?diff=split
Please have a look at the die()s – "skip" is omitted, but the rest of
the message is printed. Something like
die('skip strict_types is not enabled');
might be more appropriate.
--
Christoph M. Becker