run-tests.php exit code
| From: | Stanislav Malyshev | Date: | Wed, 28 Feb 2018 20:26:09 +0000 |
| Subject: | run-tests.php exit code | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-101940@lists.php.net to get a copy of this message | ||
Hi!
When running tests with run-tests.php, if the tests fail, the script
will exit with non-zero exit code, but only if REPORT_EXIT_STATUS is
set. This was the case since 2002 when this capability has been introduced.
I think it would be nice if we reversed the default and made the script
use exit code by default, unless NO_EXIT_STATUS is set. All usages of
this script that I know (including our own CI suite) use this setting,
and I don't think there's a good case for not using it. I think it makes
sense to default to the common use case. So:
1. Does it make sense to change the default?
2. Do we want RFC for it?
3. Can we put it in 7.1 or do we want to wait for 7.3?
Would be glad to hear everybody's thought on this.
--
Stas Malyshev
smalyshev@gmail.com