Re: Re: [RFC] Base Conversion Clowniness
| From: | Stanislav Malyshev | Date: | Sun, 18 Mar 2018 21:49:20 +0000 |
| Subject: | Re: Re: [RFC] Base Conversion Clowniness | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-101984@lists.php.net to get a copy of this message | ||
Hi!
>> https://wiki.php.net/rfc/base-convert
>
> Is there any chance to revive this RFC? There are at least three
> tickets in the bug tracker regarding the sloppy behavior of base_convert():
I think if we want to take this RFC forward it should be reduced to
either proposing one action, instead of four, or at the worst case,
choice of two for vote.
It also needs BC impact section added - AFAIK it may break some tests
and _php_math_basetozval is PHPAPI, which means besides 4 uses in core,
any extension could be using it and that extension may not be prepared
for it working differently. Which means if we change it, the failure
behavior that happens should be such that application ignoring it would
not have trouble - at least not worse than today.
--
Stas Malyshev
smalyshev@gmail.com