Re: [RFC][Discussion] Make compact function reports undefined passed variables

From: Date: Mon, 02 Apr 2018 12:08:50 +0000
Subject: Re: [RFC][Discussion] Make compact function reports undefined passed variables
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-102015@lists.php.net to get a copy of this message
> Hi Pieter. >> What I am missing here is the reason why we should break well defined behavior > > of existing functions. > Hi Pieter. >> What I am missing here is the reason why we should break well defined behavior > > of existing functions. > This is something I'd like to discuss about compact. > I'd like to know why we > skip undefined variables instead of report them. compact is use > in a large > scale by the MVC community, by passing variables in the controller and using > them in the view. > > How is the BC break for all existing code justified? > I'd like to start report this undefined variables. Would be one more way to > prevent code-smell. IMHO this belongs to the core, not to the userland. > Thanks, > -- > Gabriel Caruso Regardless of the why it is like that the fact of the matter is that it is and imho you would need a really good reason to break existing code. I still don't don't see your reason for it. Nor do I see how it is a code smell atm.

« previous php.internals (#102015) next »