Re: What to do with image2wbmp()?
| From: | Kalle Sommer Nielsen | Date: | Fri, 13 Apr 2018 04:58:23 +0000 |
| Subject: | Re: What to do with image2wbmp()? | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-102034@lists.php.net to get a copy of this message | ||
Hi
2018-04-05 14:04 GMT+02:00 Christoph M. Becker <cmbecker69@gmx.de>:
> Hi everybody!
>
> <https://bugs.php.net/73317> is still unresolved, and
> I'm not sure how
> to resolve it.
>
> TL;DR: the $threshold parameter of image2wbmp() is supposed to specify a
> *brightness threshold* for the required black and white conversion of
> the image. However, as of PHP 5.0.0 it is actually interpreted as the
> *foreground color*; all other colors are treated as background. This
> makes image2wbmp() basically identical to imagewbmp().
>
> Any suggestions on how to proceed here?
If thats the case that its basically identical, then a PHP_DEP_FE
should be sufficient for image2wbmp() and a removal in future version,
given its a rarely used function and migration is easy, even 7.4 could
potentially be fine for removal.
--
regards,
Kalle Sommer Nielsen
kalle@php.net