Re: RFC WeakRefs

Morning, I'm aware the pecl extension also has weakmap support. I think we've enough time to vote on the implementation of weakrefs, and then think about how we want weak maps to work and vote on the implementation of that. Cheers Joe On Thu, May 17, 2018 at 11:35 AM, Etienne Kneuss <colder@php.net> wrote: > On Thu, May 17, 2018 at 8:10 AM Joe Watkins <krakjoe@php.net> wrote: > >> Morning internals, >> >> I'd like to raise for discussion >> https://wiki.php.net/rfc/weakrefs >> >> Am I missing anything ? >> > > I'm all for implementing all this natively, the way it was implemented in > pecl-weakref always felt hackish and brittle. > > That said, if the plan is to subsume pecl-weakref, I suggest we also > reimplement weakmaps, which offer a convenient way of storing meta/cache > data and is not implementable in userland without trade-offs. > > Best, > > >> >> Cheers >> Joe > >