Re: [VOTE] Make compact function reports undefined passed variables
| From: | Gabriel Caruso | Date: | Sat, 09 Jun 2018 17:25:22 +0000 |
| Subject: | Re: [VOTE] Make compact function reports undefined passed variables | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-102211@lists.php.net to get a copy of this message | ||
>
> Hi Gabriel,
>
>> compact(), extract(), parse_str() (with 1 argument) and
>> get_defined_vars() are bad functions, because they access local variables
>> indirectly.
>>
>> They might be considered to be removed in the next major PHP version,
>> despite of this fix.
>>
>>
>> Thanks. Dmitry.
>>
>>
>
> Hello Dmitry.
>
> Thanks for this feedback. When I decided to create this RFC adding a
> warning, many of friends actually suggested me creating an RFC depracting
>
compact, and complaing with the same arguments as yours.
>
> Do you think we should do this already in PHP 7.3?
>
> Thanks.
>
--
Gabriel Caruso