Re: Excess arguments for internal functions
| From: | Sara Golemon | Date: | Tue, 03 Jul 2018 14:38:54 +0000 |
| Subject: | Re: Excess arguments for internal functions | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-102558@lists.php.net to get a copy of this message | ||
On Tue, Jul 3, 2018 at 5:11 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> I'd go for master only as it's technically BC breaking.
>
Ditto this.
> Some people have plans to get rid of the warning/error on too many
> arguments to internal functions to make them consistent with user
> functions, so maybe this will become unnecessary in the future. But given
> the current state of things, it would certainly be good to add
> zend_parse_parameters_none() calls where they are missing.
>
IMO, we should go the other way. Deprecate excess args in userspace
functions (making them an error in 8.0). We've had formal variadics
in userspace for a long time (5.5 IIRC), this is a solvable problem.
I also know that's not going to happen (for well defensible reasons)
and I accept that. Felt the need to state my piece though.
-Sara