Re: [RFC] Deprecate and remove continue targeting switch
| From: | Zeev Suraski | Date: | Wed, 04 Jul 2018 14:51:30 +0000 |
| Subject: | Re: [RFC] Deprecate and remove continue targeting switch | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-102575@lists.php.net to get a copy of this message | ||
On Wed, Jul 4, 2018 at 5:15 PM Nikita Popov <nikita.ppv@gmail.com> wrote:
> On Wed, Jun 27, 2018 at 11:07 PM, Stanislav Malyshev <smalyshev@gmail.com>
> wrote:
>
> > Hi!
> >
> > > In the proposal, the code is valid in all versions of PHP up to and
> > > including 7.3, *and represents the same algorithm in all versions*. The
> > > only difference would be the side-effect of issuing an additional
> > > deprecation notice; that's not "a different meaning". In PHP 8, under
> > > Nikita's proposal, the code would not be valid at all.
> >
> > I agree with PHP 7 part but not with PHP 8 part. I think we should just
> > leave the warning there.
> >
>
> I don't care particularly strongly about the actual removal, just having a
> warning would serve the purpose just as well for me.
>
> Should I just go ahead and implement the warning (with no intent of future
> removal), or do we want to still go through the RFC here?
>
I think a sensible warning is fine and doesn't really require an RFC...
Zeev