Re: [VOTE] Same Site Cookie RFC
| From: | Niklas Keller | Date: | Sun, 22 Jul 2018 16:40:54 +0000 |
| Subject: | Re: [VOTE] Same Site Cookie RFC | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-102954@lists.php.net to get a copy of this message | ||
Am So., 22. Juli 2018 um 18:11 Uhr schrieb Pedro Magalhães <mail@pmmaga.net>:
>
> On Sun, Jul 22, 2018 at 2:47 PM Niklas Keller <me@kelunik.com> wrote:
>
> > It'd be great to use an OO approach instead of "magic" array keys,
> > e.g. like this:
> >
> >
> > https://github.com/amphp/http/blob/9c0ba2f2ebfae482b3ad7a0475eb3d1f74d87949/src/Cookie/CookieAttributes.php
> >
> > Regards, Niklas
> >
>
> Hi,
>
> While I do agree with the sentiment:
> - That would have been an even greater departure from the original RFC.
> - This is currently a purely procedural API. If this were about an
> hypothetical
ResponseHeaders::setCookie it would definitely be
> the way to
> go.
>
> Regards,
> Pedro
Hey Pedro,
why does it have to be an all or nothing approach? It's perfectly fine
to have a function that accepts an object.
Regards, Niklas