Re: Re: com php-src: Remove more unecessaries percent signs: ext/zip/php_zip.c
| From: | Gabriel Caruso | Date: | Wed, 08 Aug 2018 13:20:24 +0000 |
| Subject: | Re: Re: com php-src: Remove more unecessaries percent signs: ext/zip/php_zip.c | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-103057@lists.php.net to get a copy of this message | ||
Em qua, 8 de ago de 2018 às 10:16, Sara Golemon <pollita@php.net> escreveu:
> On Wed, Aug 8, 2018 at 6:33 AM, Derick Rethans <derick@php.net> wrote:
> > On Wed, 8 Aug 2018, Gabriel Caruso wrote:
> >
> >> Commit: 953e28a92c35b81f768ae08451f6e9da6b168e51
> >> Author: Gabriel Caruso <carusogabriel34@gmail.com> Sun, 5
> Aug 2018 20:18:02 -0300
> >> Parents: f47cdd1ee0246b1d594de9ec29ce12c5279bc421
> >> Branches: master
> >>
> >> Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=953e28a92c35b81f768ae08451f6e9da6b168e51
> >>
> >> Log:
> >> Remove more unecessaries percent signs
> >
> > I don't think you should be doing this.
> >
> I'll bite. Why on Earth not?
>
Hello Derick.
I did it in an way of refactoring. Is it worth that I should rollback?
Thanks,
--
Gabriel Caruso