Re: Broken openssl tests on Travis
| From: | Alexander Kurilo via internals | Date: | Sun, 30 Dec 2018 21:05:27 +0000 |
| Subject: | Re: Broken openssl tests on Travis | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-103654@lists.php.net to get a copy of this message | ||
On 30/12/2018 23:29, Stanislav Malyshev wrote:
Hi!That's reasonable. I'll create a PR with extended certs in 12 hours or so. Thanks, Alex.There are 2 ways out: * This PR https://github.com/php/php-src/pull/3698 aims to solve the root cause: it modifies tests in order to make them generate certificates on the fly and always be sure that their expiration date is in the future (and also unties lots of tests from single certificate)This one looks like a bit large, probably reviewing it is going to take time, especially given as we have holiday season now when people are offline a lot. So I'd suggest to make a patch with a cert extended for another 3-4 months and continue to work on this patch to fix it once and for all.