Re: Suggested libgd ABI change leading to ext/gd BC break
| From: | Zeev Suraski | Date: | Tue, 15 Jan 2019 12:32:13 +0000 |
| Subject: | Re: Suggested libgd ABI change leading to ext/gd BC break | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-103745@lists.php.net to get a copy of this message | ||
> On 15 Jan 2019, at 13:13, Christoph M. Becker <cmbecker69@gmx.de> wrote:
>
> Hi!
>
> Most recently, a pull request has been submitted for libgd[1], which
> suggests to define image IO functions for several image formats
> unconditionally; if the format is not supported, the IO functions would
> fail with an error notice. This would break the current ext/gd
> configuration, since it relies on checks for the existence of these
> functions[2] to define the respective PHP functions conditionally and
> for introspection (e.g. gd_info()). In other words, building ext/gd
> against the PR would define imagecreatefromweb() even if WebP is not
> supported. This would break code relying on `if
> (function_exists('imagecreatefromweb'))` or such.
Given this downside, what is the upside of introducing this change?
Zeev