Re: str_repeat() patch
| From: | Derick Rethans | Date: | Fri, 11 Jun 2004 15:00:03 +0000 |
| Subject: | Re: str_repeat() patch | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-10404@lists.php.net to get a copy of this message | ||
On Fri, 11 Jun 2004, Alexander Valyalkin wrote:
>
> Read it:
> void *memmove(void *s1, const void *s2, size_t n);
> If s1 and s2 overlap, all bytes are copied in a preserving manner (unlike
> memcpy())
>
> And anwer the question: are s1 and s2 overlap in the str_repeat() ?
> Why don't use memcpy() instead of memmove() ?
Because it's slower and we're copying to newly allocated memory anyway
so things CAN not overlap. Also, your patch is the wrong way around.
Please stop wasting our time with those silly patches that fix nothing;
there is plenty of other good things to do to help with PHP development
(like translations as Antony mentioned).
regards,
Derick