Re: [RFC] Allow void return type variance
| From: | Girgias | Date: | Mon, 04 Feb 2019 12:09:24 +0000 |
| Subject: | Re: [RFC] Allow void return type variance | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-104115@lists.php.net to get a copy of this message | ||
I know this, I am talking about this RFC
https://wiki.php.net/rfc/covariant-returns-and-contravariant-parameters
Which has been voted and implementation is being worked on a GitHub PR:
https://github.com/php/php-src/pull/3732
Your proposal doesn't bring anything new to the table that this RFC does.
Moreover, your RFC targets the same PHP version as the
covariant/contravariant RFC.
So like said before the issue which your RFC tries to address is already
being fixed.
Also, there is no need to upgrade to PHPUnit 8 and if people want to there
is a PHP_CS_FIXER sniff which can add void return types.
Namely: void_return
George P. Banyard
On Mon, 4 Feb 2019 at 13:03, Wes <netmo.php@gmail.com> wrote:
> Covariance from no-type is already supported, since 7.0
> https://3v4l.org/I1hZs
>