Re: reasonability of change the mbfl library

Got it. Thanks. On Mon, Feb 11, 2019, 18:00 Dan Ackroyd <Danack@basereality.com wrote: > On Sun, 10 Feb 2019 at 12:29, Legale Legage <legale.legale@gmail.com> > wrote: > > > > > > > > https://github.com/php/php-src/pull/3715/commits/d868059626290b7ba773b957045e08c3efb1d603#diff-22d593ced03b2cb94450d9f9990865c8R38 > > > > To do, or not to do: that is the question. > > What do you think? > > Opening separate pull requests for separate changes is good as it > allows them to be discussed separately. That change is bundled with > the mb_str_split() changes, so it's quite hard to see what is > optimisation and what is part of the approved RFC. > > Although memory is cheap, the change appears to increase the static > allocation of memory by 128KB for something that >95% of PHP > programmers will never use, which is not a good idea. > > > show a more than 2 times speed increase. > > Lies, damn lies and statistics. > > If it takes the time to parse a megabyte string from 0.000002 to > 0.000001, no one cares. > If it takes the time to parse a megabyte string from 2 seconds to 1 > second, wow that's great! > > i.e. Saying a two times speed increase without context doesn't give > people enough information to evaluate it. > > But this would be easier to discuss as a separate PR. > > cheers > Dan >