Re: Re: PHP 7.3 dom change?
| From: | Rasmus Lerdorf | Date: | Tue, 02 Apr 2019 14:08:49 +0000 |
| Subject: | Re: Re: PHP 7.3 dom change? | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-105036@lists.php.net to get a copy of this message | ||
On Tue, Apr 2, 2019 at 2:22 AM Anatol Belski <ab@php.net> wrote:
> On Mon, 2019-04-01 at 13:42 -0700, Rasmus Lerdorf wrote:
> > On Mon, Apr 1, 2019 at 9:25 AM Rasmus Lerdorf <rasmus@lerdorf.com>
> > wrote:
> >
> > > I've been walking through the PHP 7.2->7.3 ext/dom diffs but I
> > > don't see
> > > what has caused this change: https://3v4l.org/hEmmR
> > > What did I miss?
> > >
> >
> > Tracked it down to this bug fix:
> > https://bugs.php.net/76285
> >
> Ah, I recall this one now. It was about saveHtml() not respecting
> format, had some follow ups, too. Should be harmless but might breach
> some test. Please ping, if there is a further issue.
>
Yeah, it broke some tests and there is no mention of it in the migration
docs.
-Rasmus