Re: [RFC] Always generate fatal error for incompatible method signatures
| From: | Bishop Bettini | Date: | Tue, 09 Apr 2019 09:39:54 +0000 |
| Subject: | Re: [RFC] Always generate fatal error for incompatible method signatures | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-105162@lists.php.net to get a copy of this message | ||
On Tue, Apr 9, 2019 at 4:25 AM Nikita Popov <nikita.ppv@gmail.com> wrote:
> Hi internals,
>
> A small cleanup RFC for PHP 8:
> https://wiki.php.net/rfc/lsp_errors
>
> This makes all incompatible method signature (LSP) errors fatal, rather
> than only warning in some cases. Especially after
> https://wiki.php.net/rfc/parameter-no-type-variance I
> don't think there's
> any reason to keep this backdoor in place.
>
Thank you, Nikita.
+1 from me. This inconsistency was a personal WTF moment, 3 years ago:
https://stackoverflow.com/q/37889466/2908724
On Tue, Apr 9, 2019 at 4:25 AM Nikita Popov <nikita.ppv@gmail.com> wrote:
> Hi internals,
>
> A small cleanup RFC for PHP 8:
> https://wiki.php.net/rfc/lsp_errors
>
> This makes all incompatible method signature (LSP) errors fatal, rather
> than only warning in some cases. Especially after
> https://wiki.php.net/rfc/parameter-no-type-variance I
> don't think there's
> any reason to keep this backdoor in place.
>
> Regards,
> Nikita
>