Re: Alternative approach to short tags deprecation

On Fri, Apr 26, 2019 at 3:51 PM Pedro Magalhães <mail@pmmaga.net> wrote: > On Thu, Apr 25, 2019 at 8:15 AM Nikita Popov <nikita.ppv@gmail.com> wrote: > >> Any website using short_open_tags without explicitly >> enabling it (relying on the default) will leak source code unless proper >> precautions are taken before switching to PHP 7.4. >> >> In PHP 7.4: >> * The default value of short_open_tag remains as is and enabling >> short_open_tag does not generate a deprecation warning (otherwise PHP >> would >> warn in a default config). >> > > Hi! Thanks for providing an alternative to solve this. But I'd say to > generate the deprecation notice on first use of the short tag both when the > user is relying on the default and when explicitly enabled. Although it may > be annoying that we are throwing that notice on default config, it's the > only way to warn everyone who would be affected when the default changes or > the option is removed. I'd prefer to be annoyed than the alternative. > Also, given that the notice will go away once you got rid of all your > usages of the short tag, it sounds manageable to me. > Yes, usage of <? should throw a deprecation warning regardless of whether short_open_tag is enabled by default or explicitly. What I meant here is that enabling short_open_tag does not throw a deprecation *by itself*, only the actual use of <? generates a deprecation. Nikita