Adding special case for "eval" in disable_functions INI setting
| From: | Benjamin Eberlei | Date: | Sun, 28 Apr 2019 15:46:06 +0000 |
| Subject: | Adding special case for "eval" in disable_functions INI setting | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-105484@lists.php.net to get a copy of this message | ||
Hi everyone,
I have added a patch to introduce a special case for eval when listed in
disable_functions INi setting. From a developer perspective it shouldn't be
necessary to know that eval is not a function but a language construct.
This is why I think this special case is needed rather than adding a new
INI setting.
https://github.com/php/php-src/pull/4084
The patch fixes https://bugs.php.net/bug.php?id=62397
It currently targets 7.4 branch, but the way its implemented I think it
could be merged into the stable branches.
Should I target the PR for 7.1/7.2 or where do the PMs think this should go?
greetings
Benjamin