Re: [PATCH] apache2handler memory leak fix

On Fri, Jun 18, 2004 at 02:13:05PM +0200, Magnus Määttä wrote: > Hi! > > On Friday 18 June 2004 12.30, Joe Orton wrote: > > It's simpler to just use the ap_r* interfaces in the the handler SAPI > > for 2.0, this improves network usage by allowing httpd to buffer as > > necessary, and fixes a bug where ub_write is unnecessarily pmemdup'ing > > the string (it could have used a transient bucket to avoid that; the > > apache2filter got this right), and stops re-using an output brigade > > which is now or at least will soon be a 2.0 API violation. > > > > (this restores constant memory use for an arbitrary length response) > > I've attached a forward port of this patch for HEAD. > This also fixes bug #28113. Ah, thanks Magnus. Note that flush() may still leak a small amount of memory but this is what I'm working to fix in httpd. Regards, joe