Re: Merging fuzzing SAPI into core

On Tue, Jul 30, 2019 at 6:15 PM Johannes Schlüter <johannes@schlueters..de> wrote: > On Tue, 2019-07-30 at 13:28 -0400, Bishop Bettini wrote: > > On the other, I've found it refreshing working in a > > slender repo that doesn't have all the history and process rules. > > This is good for external (non-core and non-extension) collaborators, > > particularly allowing write access to those who wouldn't want or need > > write access to engine code. > > > I am also not sure having this independent makes it simpler for > outsiders to contribute. You maybe ease the submission process, but > setting it up becomes harder as you need to clone to repos, put it in > the right place, make sure you are in compatible branches (on next PHP > 7 like API change this might become relevant, maybe even sooner as it > goes into different extension's APIs where we observe BC a bit less) > > I think merging it into PHP makes the most sense, also for signaling to > the outside that we care about security by having fuzzing routines as > core part of the thing. > Fair points, Johannes and Stas. I've no objection to moving the SAPI into php/php-src.