Re: [RFC] Union Types v2

Hi Côme > Huge "no" from me on using github for discussing RFCs. Care to elaborate why? The majority seems to like it. Though I am also curious about Nikita's experience with it, as he is the one having to process the feedback. Kind regards Brent On 5 Sep 2019, 11:40 +0200, Côme Chilliet <come@opensides.be>, wrote: > Le mercredi 4 septembre 2019, 10:26:09 CEST Nikita Popov a écrit : > > As an experiment, I'm submitting this RFC as a GitHub pull request, to > > evaluate whether this might be a better medium for RFC proposals in the > > future. It would be great if we could keep the discussion to the GitHub > > pull request for the purpose of this experiment (keep in mind that you can > > also create comments on specific lines in the proposal, not just the > > overall discussion thread!) Of course, you can also reply to this mail > > instead. The final vote will be held in the wiki as usual. > > Huge "no" from me on using github for discussing RFCs. > > Huge "yes" on the RFC content. > > > * Only supports "false" as a pseudo-type, not "true". > > I think it would make sense to support true as well as I’ve seen a lot of cases of functions > returning either an error string or TRUE on success. > So that would be string|true. > > Côme > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >