Re: Re: [VOTE] Reclassifying engine warnings

On Wed, Oct 2, 2019 at 8:24 AM Nikita Popov <nikita.ppv@gmail.com> wrote: > * The "Undefined array index" case. This one passed the vote with an exact > 2/3 majority, so I'm a bit uncomfortable making changes here. This is also > the only case where convincing usability concerns have been brought > forward, primarily around the $array[$key]++ example. I'm not yet decided > on what to do here and whether we should pursue additional library or > language features first. > > We raised margins to 2/3 to avoid having to feel bad about narrow majorities. I say this as someone who was quite tempted to vote "Keep Notice" which on retrospect would have changed the entire outcome based on that one vote. If this had been a simple majority vote and it had pass by like.... 52%-48%, then obviously that's not a mandate worth making potentially catastrophic changes over, but this is 67% to 33%, it feels like you're okay here. -Sara