Adding explicit intent for SWITCH/CASE fall through?
| From: | Mike Schinkel | Date: | Thu, 17 Oct 2019 20:54:51 +0000 |
| Subject: | Adding explicit intent for SWITCH/CASE fall through? | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-107568@lists.php.net to get a copy of this message | ||
Hi All,
Before creating an RFC I wanted to get reactions to the idea of adding FALLTHROUGH option to
SWITCH/CASE for when the developer explicitly want logic to fall through to the next case and does
not want to use a BREAK.
My simples motivation for this feature is that my IDE (PhpStorm) always flags CASE statements w/o
BREAKs because it cannot know when I intend for the logic to fallthrough and not break. If there
was an optional FALLTHROUGH then my IDE could flag any CASE statements that do not have a
FALLTHROUGH or BREAK — which would indicate an error of my intent — and avoid flagging all the
situations where I intentionally want it to fall through.
Beyond that, this might also be useful for other static analysis tools such as PhpStan.
Ust
Additionally it could be added in 8.0 and then in 8.1 flagged with a warning when a CASE does not
have one for the two, but only if people don't object to this. While I know some on this list
feel strongly that warnings must come with to future plans to generate errors I would personally be
100% okay if it indefinitely generated only a warning.
In summary I want a mechanism to be allow me to explicitly indicate my intent with respect to
SELECT/CASE statements. What do you think? Is this worthy of an RFC, or is there some reason a
majority would object to such an addition?
Thanks in advance.
-Mike