Re: configure bug with static openssl 1.1.1? - bugid 77288
| From: | Nikita Popov | Date: | Wed, 23 Oct 2019 09:08:51 +0000 |
| Subject: | Re: configure bug with static openssl 1.1.1? - bugid 77288 | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-107641@lists.php.net to get a copy of this message | ||
On Mon, Oct 14, 2019 at 1:44 PM Jan Ehrhardt <phpdev@ehrhardt.nl> wrote:
> Nikita Popov in php.internals (Mon, 14 Oct 2019 11:46:57 +0200):
> >On Mon, Oct 14, 2019 at 11:30 AM Nikita Popov <nikita.ppv@gmail.com>
> wrote:
> >
> >> On Mon, Oct 14, 2019 at 11:22 AM Nikita Popov <nikita.ppv@gmail.com>
> >> wrote:
> >>
> >>> The fact that "-pthread" gets stripped from LIBS might be a bug.
> >>
> >> Looks like the -pthread stripping happens here:
> >>
>
> https://github.com/php/php-src/blob/5197d0cd5e1f4581db1beca1260e1315368ea911/build/php.m4#L371-L377
> >>
> >> It doesn't get stripped as much as relocated to EXTRA_LDFLAGS (for
> static
> >> builds, for shared it goes into SHARED_LIBADD). However EXTRA_LDFLAGS is
> >> only used when linking libraries, while programs use
> EXTRA_LDFLAGS_PROGRAM.
> >> This seems like an oversight, and it should be added to both.
> >
> >This should be fixed with
> >
>
> https://github.com/php/php-src/commit/c518932c0326a938f0fd0254f2adb03b1cddfbca
> .
> >Now using just
> >
> >./configure --disable-all --with-openssl OPENSSL_LIBS="-l:libssl.a
> >-l:libcrypto.a -ldl -pthread"
> >
> >works for me.
>
> Wow. Improvement of a patch back in Jun 13, 2005:
>
>
> https://github.com/php/php-src/commit/54d85cbfdadeca491478e3894707534e2c9ccd1f
> Original bug: https://bugs.php.net/bug.php?id=31256
>
> Thanks. Will you backport the commit to PHP 7.2?
>
Sorry, I forgot about this. Now backported in
https://github.com/php/php-src/commit/fa89c41f378894dc623374dd03c36a9fa16410a9
.
Nikita