Re: [RFC] "use global functions/consts" statement
| From: | tyson andre | Date: | Thu, 02 Jan 2020 01:37:45 +0000 |
| Subject: | Re: [RFC] "use global functions/consts" statement | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-107955@lists.php.net to get a copy of this message | ||
> Do you have plans to use the https://github.com/php/php-rfcs
> to promote the discussion as well, the same way
we did https://github.com/php/php-rfcs/pull/1
for the Typed Properties RFC?
No, I have no plans to switch to GitHub. At the time of writing, https://github.com/php/php-rfcs/blob/master/README.md
has the following note about not submitting PRs, so I decided against trying out the experimental
RFC process.
> This is just a one-off experiment for now, we'll have to discuss whether we want to move
> the RFC process towards this separately. *This repository may be abandoned. Please don't submit
> PRs for now.*
1. I'm not sure if there's a consensus on https://externals.io/message/107747#107747
("GitHub RFC workflow").
2. I expect this RFC to be smaller in scope (of discussion) than adding union types to the language.
Other thoughts on "GitHub RFC workflow" (Sorry for this being off topic- I don't know
how to reply to a mailing list thread I don't have in my inbox while preserving threading, from
Outlook in a browser. The "In Reply To" header seems like what I'd want, but is
impractical to set with this setup):
- It seems slightly time consuming and error-prone for formatting (but doable) to migrate from
markdown to dokuwiki after the RFC is reviewed on GitHub (I see this was already mentioned). Maybe
publishing the dokuwiki markup as plain text, linking to the wiki, and having code review on that
would be a better option to write (but harder for reviewers unfamiliar with the dokuwiki format).
Tooling (use pandoc or something else to convert from HTML (rendered by wiki) to markdown for the
github PR) may help with that process - I'm not familiar with the best options. dokuwiki only
has official support for export to odt and xhtml, as far as I can tell
- If I linked to a GitHub PR as a secondary source of reviews to the email thread (instead of the
main source), it might be splitting up the discussion, and reviewers would miss or duplicate
comments.
Thanks,
- Tyson