Re: Changing the generated name for anon classes

From: Date: Thu, 06 Feb 2020 13:44:57 +0000
Subject: Re: Changing the generated name for anon classes
References: 1  Groups: php.internals 
Request: Send a blank email to internals+get-108413@lists.php.net to get a copy of this message
Nikita, Just to chime in here: would it be wise to add an interface instead? (this would automatically be added by the engine) so that the consumer of a generated class could *really* know based on the interface that it's a generated anonymous class instead of string type checking the classname? Relying on some interface seems te be more future proof than just changing the string to look up ;) Keep up the good work! Regards Robin Op do 6 feb. 2020 om 12:21 schreef Nikita Popov <nikita.ppv@gmail.com>: > Hi internals, > > Based on a suggestion by Nicolas Grekas, > https://github.com/php/php-src/pull/5153 changes the generated > name for > anonymous classes to include the name of the parent class or first > interface. So instead of just class@anonymous, you'll see something like > EventHandler@anonymous in error messages, for example. > > There's a minor BC break here, for code checking for a "class@anonymous" > prefix, which should be easy to rectify by checking for "@anonymous" > instead. > > What do people think about doing this change? > > Regards, > Nikita >

« previous php.internals (#108413) next »