Re: Re: [RFC] deprecate md5_file and sha1_file

On Mon, 10 Feb 2020, 23:36 Mark Randall, <marandall@php.net> wrote: > On 10/02/2020 21:49, Tom Van Looy via internals wrote: > > I suggest to deprecated the functions md5_file() and sha1_file(). This > will > > make people think about upgrading to a better alternative. > > It won't. > You can lead a horse to water but you can't make it drink. If this is explained in the upgrade guide, that's all we can do. I would limit the deprecation to these two functions. Not the entire algo's, because indeed that's not going to happen. I give you another case. What if a new user finds only these two functions and starts using them because a sha512_file() etc. does not exist? If the functions are deprecated at least that would be explained in the docs. Tom >