Re: [RFC] deprecate md5_file and sha1_file
| From: | Tom Van Looy via internals | Date: | Tue, 11 Feb 2020 06:25:04 +0000 |
| Subject: | Re: [RFC] deprecate md5_file and sha1_file | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-108451@lists.php.net to get a copy of this message | ||
On Tue, 11 Feb 2020, 06:59 Stanislav Malyshev, <smalyshev@gmail.com> wrote:
> Hi!
>
> > I suggest to deprecated the functions md5_file() and sha1_file(). This
> will
>
> Not sure what's the point of it. SHA1 and MD5 didn't change. The
> recommendations for their usage has changed, but we generally don't use
> deprecation warnings to improve users' code and recommend them how to
> structure their code better.
Yes that was my point with "modern php". The recommendation changed.
It seems like most people in this discussion like to keep the functions. I
didn't expect that.
Thanks for the feedback and the arguments all!
Tom