Re: [RFC] token_get_all() TOKEN_AS_OBJECT mode
| From: | Marco Pivetta | Date: | Fri, 14 Feb 2020 13:44:10 +0000 |
| Subject: | Re: [RFC] token_get_all() TOKEN_AS_OBJECT mode | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-108576@lists.php.net to get a copy of this message | ||
On Fri, Feb 14, 2020 at 2:38 PM Sara Golemon <pollita@php.net> wrote:
> Thanks for picking it up, and I agree with your response to Larry. As nice
> as it would be to lazy iterate, the scanner is just in NO shape to tolerate
> reentering userspace and potentially reinvoking the scanner before the
> first run through is done.
>
If this is the current state, maybe it would suffice to declare the return
type as
iterable, and return a strict (fully populated) structure in a
first implementation, later to be changed to an iterator, if applicable?
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/