Re: New PCRE function

On Wed, 19 Feb 2020 at 18:15, Mike Schinkel <mike@newclarity.net> wrote: > > On Feb 19, 2020, at 12:10 PM, Rowan Tommins <rowan.collins@gmail.com> > wrote: > > > >>> On Wed, Feb 19, 2020 at 4:20 PM David Rodrigues < > david.proweb@gmail.com> > >>> wrote: > >>> > >>>> Maybe you can set all this messages as lowercase? That way we can use > it > >>>> more easily. > >> > > > > > > > >> On Wed, 19 Feb 2020 at 16:50, Mike Schinkel <mike@newclarity.net> > wrote: > >> > >> I am however influenced by Go which specifies that all error messages > >> should be lowercased for the exact reason that David suggests. > >> > > > > > > Like Nico, I'm not sure what lowercase is easier for. Can either of you > > expand on the reasoning / use case? > > > From > https://github.com/golang/go/wiki/CodeReviewComments#error-strings > > "Error strings should not be capitalized (unless beginning with proper > nouns or acronyms) or end with punctuation, since they are usually printed > following other context. That is, use fmt.Errorf("something bad") not > fmt.Errorf("Something bad"), so that log.Printf("Reading %s: %v", filename, > err) formats without a spurious capital letter mid-message. This does not > apply to logging, which is implicitly line-oriented and not combined inside > other messages." > > > -Mike > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php But that's Golang's policy, so either we change all error messages to be lower case or we keep it consistent with what PHP currently does. Moreover, I'm not sure I see a massive benefit in having it in lowercase (especially just one random function which behaves not like others) Best regards George P. Banyard