Re: Re: [VOTE] Stringable
| From: | Nicolas Grekas | Date: | Tue, 03 Mar 2020 10:09:48 +0000 |
| Subject: | Re: Re: [VOTE] Stringable | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-108820@lists.php.net to get a copy of this message | ||
>
> Ironically, this broke Symfony ;)
>
> > Fatal error: Access level to class@anonymous::__toString() must be
> public (as in class Stringable) in
> /home/vsts/work/1/s/symfony/src/Symfony/Component/String/Tests/LazyStringTest.php(110)
> : eval()'d code on line 1
>
>
>
Indeed!
Fixed in https://github.com/symfony/symfony/pull/35935
But it seems that this was already a warning before:
>
> > Warning: The magic method __toString() must have public visibility and
> cannot be static in /in/3m4Za on line 4
>
> So it doesn't seem like a big issue in practice.
>
I agree :)