Re: [Discussion] Promoting declare failure notices to exceptions?

On Sat, 14 Mar 2020 at 21:19, Mark Randall <markyr@gmail.com> wrote: > Greetings, > > I have created a PR that will throw exceptions when using define() > with invalid types or when trying to redefine. > > Trying to redefine a constant or define a bad constant would throw a > ValueError on the name parameter, trying to pass an unsupported type > would give a TypeError on the value parameter. > > Normal promotions are fairly run of the mill, however for some utterly > bizarre reason the existing behaviour is to print a notice and not a > warning as with almost all other functions that are failing. > > Is there a good reason not to promote these to exceptions? > > https://github.com/php/php-src/pull/5265 > > -- > Mark Randall > marandall@php.net > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php I'm all for it, I wouldn't a lot of code to be affected by it as that code would be truly broken. Best regards George P. Banyard