Re: [RFC] Allow trailing comma in parameter lists

On 26/03/2020 18:52, Nikita Popov wrote:

Hi internals, This has been declined in the past, but I just keep making this mistake, and believe it deserves reconsideration... https://wiki.php.net/rfc/trailing_comma_in_parameter_list Nikita

Hi Nikita, While I'd personally be fine with this change, I think we should understand why the previous proposal failed rather than just hoping the vote goes differently this time. Specifically, this vote was only 3 years ago, and although it achieved a majority, was well short of the 2/3 requirement: https://wiki.php.net/rfc/list-syntax-trailing-commas#functionmethod_arguments_declarations_calls Notably, a followup RFC proposing only function *calls* allow trailing commas, passed a few months later, and includes this specific rationale: https://wiki.php.net/rfc/trailing-comma-function-calls#wait_didn_t_we_just_vote_on_this

I was contacted by many “no” voters saying that they would have voted “yes” for function calls, but “no” for function declarations. ThisRFC proposes allowing a trailing comma in function call syntax only.

Looking back at the discussions from 2017, I can see a couple of people taking that position, but not expanding on it. Does anyone still hold that view, and want to explain why they feel that way? Side-note - here's a quick timeline of related RFCs: - Feb 2013: https://wiki.php.net/rfc/trailing-comma-function-args - function calls only, rejected 15:20 - Oct 2015: https://wiki.php.net/rfc/revisit-trailing-comma-function-args - withdrawn in favour of next RFC - Nov 2015, voted Jan 2017: https://wiki.php.net/rfc/list-syntax-trailing-commas - function calls and parameters, rejected 24:20 - Oct 2017: https://wiki.php.net/rfc/trailing-comma-function-calls - function calls only, passed 30:10 - Mar 2020: https://wiki.php.net/rfc/trailing_comma_in_parameter_list - function parameters only... Regards, -- Rowan Tommins (né Collins) [IMSoP]