Re: Interfaces and ReflectionMethod::isConstructor()
| From: | Marco Pivetta | Date: | Mon, 30 Mar 2020 08:14:56 +0000 |
| Subject: | Re: Interfaces and ReflectionMethod::isConstructor() | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-109446@lists.php.net to get a copy of this message | ||
Hey Sebastian,
<http://ocramius.github.com/>
On Mon, Mar 30, 2020 at 8:45 AM Sebastian Bergmann <sebastian@php.net>
wrote:
> Am 28.03.2020 um 08:44 schrieb Sebastian Bergmann:
> > I can deal with this in PHPUnit's code either way, but need to know what
> > the plan here is.
>
> I worked around the issue now [1].
>
> --
> [1]
>
>
> https://github.com/sebastianbergmann/phpunit/commit/477798f6b226e830d358bc102cd02bb2e52cfdb2
>
Patch makes a lot of sense, but is it done that way to still support 7.x?
I'm not sure (don't have a local build of PHP 8.x-dev) if
https://wiki.php.net/rfc/remove_php4_constructors
is going to come in
effect as "PHP4 constructors are finally gone".
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/