Re: extended objects with read_property and get_property_ptr_ptr
| From: | Zeev Suraski | Date: | Wed, 07 Jul 2004 17:30:16 +0000 |
| Subject: | Re: extended objects with read_property and get_property_ptr_ptr | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-10952@lists.php.net to get a copy of this message | ||
At 16:32 07/07/2004, Rob Richards wrote:
Attached is a patch for zend_execute.c which will fall to read_property if get_property_ptr_ptr returns NULL in zend_fetch_property_address_inner. Hopefully this is the correct fix as it didnt break any tests and resolves the issue I hit.It's not a correct fix :I get_ptr_ptr must return the address of an allocated zval *, one which can later be separated, etc. T(result->u.var).var.ptr doesn't fall into that category - it can be gone in the next opcode... The only safe way to return a zval ** is for the underlying object model to implement get_ptr_ptr... Zeev