Re: Renaming PhpAttribute to Attribute

From: Date: Tue, 28 Apr 2020 15:59:22 +0000
Subject: Re: Renaming PhpAttribute to Attribute
References: 1 2  Groups: php.internals 
Request: Send a blank email to internals+get-109884@lists.php.net to get a copy of this message
Hello, > Attribute is certainly too generic, and will needlessly collide > with code > in the wild. Could you provide any examples as to where '\Attribute' is being used in the wild? I haven't seen a single project that has an Attribute class and uses the global namespace. > I suggest circling back to the PHP\ namespace discussion, and > having > PHP\Attribute if you really have a problem with current naming. In regards to \PHP namespace, I believe this is future scope and because it's still not voted into PHP, we should do the things like we always did. I believe that the reasoning behind calling the attribute's class as PhpAttribute was because the author wanted to be consistent with PhpToken. But since PhpToken was called as such to not raise ambiguity to what kind of a token it is, I believe that the attribute class should be simply named Attribute instead. Best regards, Benas Seliuginas

« previous php.internals (#109884) next »