Re: [RFC] [DISCUSSION] Make constructors and destructors return void
| From: | Alexandru Pătrănescu | Date: | Wed, 17 Jun 2020 00:44:21 +0000 |
| Subject: | Re: [RFC] [DISCUSSION] Make constructors and destructors return void | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-110613@lists.php.net to get a copy of this message | ||
Hi Benas,
This looks good to me.
Can you do a research on top 1k-2k most used composer packages and verify
how small the BC break it is?
Also, a suggestion on how to fix the BC issue if it exists could be
mentioned I guess.
Thank you,
Aled
On Wed, Jun 17, 2020, 02:11 Benas IML <benas.molis.iml@gmail.com> wrote:
> Hey internals,
>
> This is a completely refined, follow-up RFC to my original RFC. Based on
> the
> feedback I have received, this PR implements full validation and implicitly
> enforces
void rules on constructors/destructors while also
> allowing to
> declare an **optional** explicit void return type. Note, that
> there is a
> small but justifiable BC break (as stated by the RFC).
>
> RFC: https://wiki.php.net/rfc/make_ctor_ret_void
>
> Best regards,
> Benas Seliuginas
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>