Re: [RFC] [VOTE] Make constructors and destructors return void

On Fri, Jul 3, 2020 at 11:04 AM Benjamin Eberlei <kontakt@beberlei.de> wrote: > On Thu, Jul 2, 2020 at 11:12 PM Benas IML <benas.molis.iml@gmail.com> > wrote: > > > Hey internals, > > > > I have opened the voting for the RFC, let's hope everything is going > > to be smooth :). If you have any other questions, let me know! > > > > RFC: https://wiki.php.net/rfc/make_ctor_ret_void > > > > Best regards, > > Benas Seliuginas > > > > Hi Benas, > > I wanted to raise what I believe is an issue with the secondary vote going > against PHP policy to introduce a BC break in 8.1, I would imagine policy > overrules voting decision here and it wouldn't matter what people voted > for, it will only be removed at the earliest in 9.0 > To answer the policy question: RFCs can override or change general policy -- after all, policy is decided through the RFC process itself. To give a precedent where this happened for a "pure" BC break: https://wiki.php.net/rfc/too_few_args But more generally, many RFCs will have "minor" BC breaks as part of a larger proposal, and RFC acceptance also always implies that we consider those BC breaks acceptable for the targeted PHP version. Now, whether this RFC actually makes a sufficient case to disregard policy here is a different question, and at the discretion of the voters. Regards, Nikita