Re: [RFC] [Discussion] Shorter Attribute Syntax Change

On Sun, Aug 2, 2020 at 10:06 AM Derick Rethans <derick@php.net> wrote: > On Wed, 29 Jul 2020, Benjamin Eberlei wrote: > > > Personally I favor #[] myself, but there has been a vote with a > > substantial participation choosing @@. Overturning this democratic > > outcome should require **significant** technical arguments, otherwise > > this RFC would provide problematic precedent for any RFC to be > > overturned by arbitrary revoting. > > > > The arguments the RFC brings forward don't convince me that we should > > pick #[] over @@. > > However, one other thing just came to light where the "Shorter Syntax" > RFC was unclear about: no longer supporting grouping. > > Changing the accepted << .. >> syntax breaks something that > was accepted through "Attribute Amendments": grouping, as per > > https://wiki.php.net/rfc/attribute_amendments#group_statement_for_attributes > > The switch to @@ does now not allow for this, but we haven't spefically > voted on we wanted to get rid of grouping. The Shorter Syntax RFC does > talk about it in "Verbosity" > (https://wiki.php.net/rfc/shorter_attribute_syntax#verbosity), but > that's not a technical reason, just opinion about readability. Hi Dereck, The Shorter Attribute Syntax RFC explicitly mentioned that the @@ syntax would supersede the grouped attributes proposal: [1] > this proposal does not conflict with the Attribute Amendments RFC, > with the exception that if the @@ syntax is accepted, it will > supersede the syntax for grouped attributes. This was also documented in the Attribute Amendments RFC itself: [2] > This feature would be superseded by any other RFC getting accepted > that changes the syntax. I agree with Benjamin that the democratic outcome of the vote between <<>>, @@, and #[] should not be overturned unless there is a serious technical problem with the implementation, otherwise we set precedent for someone to overturn any RFC by arbitrarily re-voting until they get the result they want. Best regards, Theodore [1]: https://wiki.php.net/rfc/shorter_attribute_syntax#unaffected_functionality [2]: https://wiki.php.net/rfc/attribute_amendments#group_statement_for_attributes