Re: Allow sleep() to accept non-integer values
| From: | Rowan Tommins | Date: | Tue, 11 Aug 2020 08:53:43 +0000 |
| Subject: | Re: Allow sleep() to accept non-integer values | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-111449@lists.php.net to get a copy of this message | ||
On Tue, 11 Aug 2020 at 08:31, Michael Voříšek - ČVUT FEL <
vorismi3@fel.cvut.cz> wrote:
> I am the author of https://github.com/php/php-src/pull/5961 ,
> please
> provide feedback.
>
This idea makes a lot of sense to me as a user (I'll leave comments on the
implementation to those with more C experience).
I'm pretty sure I've accidentally written things like "sleep(1.5)" in the
past, and think there is a strong argument for changing something here:
> Another reason is that sleep(0.1); is silently accepted now (even with
strict types enabled), but the input is casted to 0 and thus producing
unexpected behaviour if the user is not aware of the current method
prototype.
Unless there are problems with the implementation, this seems like a
straight-forward win.
Regards,
--
Rowan Tommins
[IMSoP]