Re: [RFC] Shorter Attribute Syntax Change RFC 0.2

I have one major issues with the examples. Syntax Side by Side: The properties are annotated (with attributes) inline which is the opposited of common usage now (with annotation). Discussion on Grouping Pro/Cons: But since this depends on the coding style the user... No, this should be consulted with PSR people and their recommendations should be discussed there. Enclosing Delimiters - Complexity of Attribute Declaration: there should be example on left side without and on right side with - I do not see how delimiters will actually help Discussion on grep'ability - the arguments against are theoretical, imports are not very often aliased, this is clearly a con for grouping Excl. the <<>> syntax (which I think is not good because of generics that will come sooner or later), all other examples are about good prefix for attributes. So I think we should discuss the best prefix and separately if we want to allow grouping with "[" or even with "{". The most prefer syntax can be @: for ungrouped attributes and @:[] for grouped one, but this combination is not discussed there. With kind regards / Mit freundlichen Grüßen / S přátelským pozdravem, Michael Voříšek On 16 Aug 2020 11:36, Benjamin Eberlei wrote:

We have updated the RFC with all (hopefully) of the feedback from this discussion: https://wiki.php.net/rfc/shorter_attribute_syntax_change Most notable changes are: - A new section with several subsections on the benefits of a closing delimiter / enclosing syntax. - A section on grouping pro/cons - Inclusion of @: as per Theodores request We are looking for further feedback from the community. On Tue, Aug 4, 2020 at 3:46 PM Derick Rethans <derick@php.net> wrote: Hi, Out of Banjamin's suggestion[1 [1]], I've updated the Shorter Attribute Syntax Change RFC to reflect that process: https://wiki.php.net/rfc/shorter_attribute_syntax_change Patches and comments welcome. FWIW, this has an excemption from the RM Sara as per [2 [2]]: * Shorter Attribute Syntax Change - Joe/Derick - Please make sure this RFC moves along and reaches conclusion by beta3, as discussed previously. cheers, Derick [1] https://externals.io/message/111218#111261 [2] https://externals.io/message/111286#111286 -- PHP 7.4 Release Manager Host of PHP Internals News: https://phpinternals.news Like Xdebug? Consider supporting me: https://xdebug.org/support https://derickrethans.nl | https://xdebug.org | https://dram.io twitter: @derickr and @xdebug -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Links: ------ [1] https://externals.io/message/111218#111261 [2] https://externals.io/message/111286#111286