Re: Should hash comments be deprecated?
| From: | Andrea Faulds | Date: | Fri, 21 Aug 2020 21:08:24 +0000 |
| Subject: | Re: Should hash comments be deprecated? | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-111674@lists.php.net to get a copy of this message | ||
Hi,
Theodore Brown wrote:
Hi internals, Since the #[] attribute syntax is currently winning the vote, [1] it makes me wonder if the use of comments starting with # should be deprecated. Otherwise it seems like we could be setting ourselves up for long-term confusion between attributes and comments, and also inconsistency with other comments (it will no longer be safe to assume that a line can be commented out by simply adding # at the beginning). What do others think? Theodore [1]: https://stv-results.theodorejb.me/php/?rfc=shorter_attribute_syntax_changeThere is a critical use-case for comments beginning with the hash symbol, namely UNIX shebang lines. In theory we could special-case those and disallow the symbol in every other use, but… well, that seems like a bit of a shame. Regards, Andrea